Add strict mode directive to module bundles #8710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
devongovett
reviewed
Dec 21, 2022
mischnic
force-pushed
the
strict-mode-directive
branch
from
5670c34
to
14014d6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
mischnic
commented
Dec 22, 2022
| @@ -1 +1 @@ | |||
| output = require('./'); | |||
| global.output = require('./'); | |||
There was a problem hiding this comment.
Due to nodejs/node#38918 (comment) (only needed if the value being assigned is a function)
mischnic
commented
Dec 22, 2022
| @@ -3611,7 +3611,8 @@ describe('scope hoisting', function () { | |||
| assert.equal(output, 42); | |||
| }); | |||
|
|
|||
| it('builds commonjs modules that assigns to module.exports before exports', async function () { | |||
| // TODO this should be working | |||
| it.skip('builds commonjs modules that assigns to module.exports before exports', async function () { | |||
There was a problem hiding this comment.
The output right now is
parcelRequire.register("5CKoA", function(module, exports) {
module.exports = 42;
module.exports.foo = 27;
});which is invalid in strict mode (something like "cannot add property to number")
There was a problem hiding this comment.
should we just change the first assignment to an object?
There was a problem hiding this comment.
Ah, forgot to include the input code:
module.exports = 42;
exports.foo = 27;
so this really is a failing test (just like the other one with the undeclared variable).
(The correct behaviour here is that "42" is exported and the second line does nothing)
mischnic
commented
Dec 22, 2022
mischnic
commented
Dec 22, 2022
devongovett
approved these changes
Dec 22, 2022
|
@mischnic do you still want to merge this? |
|
Hi, thanks a lot for the progress so far! I was wondering if there is any plan to merge this fix, or if there is an alternative workaround/fix planned? Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8706