Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset.addURLDependency, incorrect package.json fix #892

Closed

Conversation

DeMoorJasper
Copy link
Member

closes #787

Less drastic alternative than #891, although this is slightly slower.

@devongovett
Copy link
Member

devongovett commented Feb 27, 2018

Ah, good catch! Seems like this would be solved by just not using the package name in generateBundleName. Not sure we really need that anyway with #872. That way we don't need to do a resolve call in addURLDependency. WDYT?

@DeMoorJasper
Copy link
Member Author

DeMoorJasper commented Feb 27, 2018

@devongovett Isn't it still necessary for that RFC?

We also support the -o or --out-file CLI option, which would override the default name for the entry file. If not provided, and the entry file matches main in package.json, use the package name.

If i'm mistaken it could still be used as a temporary patch untill the RFC gets into implementation phase I guess.

@devongovett
Copy link
Member

Yeah, but actually not sure how useful that will be if we are hashing things anyway. Closing this one, should be fixed by #934.

@devongovett devongovett closed this Mar 2, 2018
@devongovett devongovett deleted the jasper/addURLDependency-incorrect-pkg-fix branch March 2, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS file (vuetify) not bundled correctly, causing 404
2 participants