Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Updated weights for v900 release #1193

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

gilescope
Copy link
Contributor

@gilescope gilescope commented Apr 21, 2022

notable changes:

  • batch_all has db read and write added. (There don't seem to be any changes to the utilities pallet in substrate).

  • remark_with_event has flipped to weight 0 on polkadot. (I'm fine with this as the extrinsic length is where the remark fee is charged.)

Everything else looks pretty tight - not much change from last time.

remark_with_event has flipped to weight 0 on polkadot.
@gilescope gilescope added A0-pleasereview B0-silent Changes should not be mentioned in any release notes labels Apr 22, 2022
@gilescope gilescope added this to the statemint-v9.0.0 milestone Apr 22, 2022
@NachoPal
Copy link
Contributor

I can not find either a explanation for the extra read/writes for batch_all

@gilescope
Copy link
Contributor Author

Problemo: https:/paritytech/cumulus/tree/giles-update-weights/polkadot-parachains/statemint/src/weights

If you look at that url you can see that not all the weights files were updated.

@NachoPal
Copy link
Contributor

Problemo: https:/paritytech/cumulus/tree/giles-update-weights/polkadot-parachains/statemint/src/weights

If you look at that url you can see that not all the weights files were updated.

What do you mean? we are running the benchmarks for 11 pallets and I see in the PR that 33 files were changed, which make sense since we have 3 runtimes.

@gilescope
Copy link
Contributor Author

So talking with Oliver, the not updated weights files basically have been fixed since year dot.
The block_weights.rs and extrinsics_weights.rs will be able to be benchmarked by the command benchmark overhead but this is not exposed yet to polkadot-collator. (Hopefully by the next release we can start autogening those).

The paritydb and rocksdb files need a bit more thought as to how they get autogened as "it basically needs to create inherents, signed extrinsics and a transaction in a somehow runtime agnostic way".

Oliver has kindly documented this all here: paritytech/substrate#11246

So I think there's no reason not to merge what we have and look forward to an expanded benchmarking scope for next release.

@gilescope
Copy link
Contributor Author

gilescope commented Apr 22, 2022

batch_all has db read and write added. - we note that polkadot had the same added and was approved: https:/paritytech/polkadot/blob/1d6660fc484bcad9756424708de4c3271e2eada5/runtime/polkadot/src/weights/pallet_utility.rs#L60

@gilescope gilescope merged commit 7cf357e into release-parachains-v9.0.0 Apr 22, 2022
@gilescope gilescope deleted the giles-update-weights branch April 22, 2022 14:21
@ggwpez
Copy link
Member

ggwpez commented May 3, 2022

For posterity:
The DB accesses in batch_all most likely come from the fact that we changed the transactional layer to be saved in storage now. Introduced here I think paritytech/substrate#10808.
This incurs additional read/writes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants