Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improve build times by disabling wasm-builder in no_std #2308

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Mar 11, 2023

There is no need to compile wasm-builder in no_std as we skip the compilation of the crate any way. So, we can also directly disable wasm-builder as dependency in no_std to improve build times.

There is no need to compile wasm-builder in `no_std` as we skip the compilation of the crate any
way. So, we can also directly disable wasm-builder as dependency in `no_std` to improve build times.
@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 11, 2023
@xlc
Copy link
Contributor

xlc commented Mar 12, 2023

parachain teams should do similar change to improve build time?

@bkchr
Copy link
Member Author

bkchr commented Mar 12, 2023

parachain teams should do similar change to improve build time?

You don't need to, but you can. ;)

Comment on lines +1 to +2
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: Apache-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not putting the year anymore?

I think all the licenses should be updated in a dedicated PR, as this distracts from other changes here and is incomplete in itself. We have a license scanner tool for this which we already used in Polkadot. cc @rzadp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure that it distracts from the changes. Yes we are not putting the year anymore.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, feel free to ask me to set up the licence scanner CI check here if it has proven useful in Polkadot.

@bkchr bkchr requested a review from a team March 20, 2023 08:36
@bkchr bkchr merged commit 5aeff50 into master Mar 20, 2023
@bkchr bkchr deleted the bkchr-disable-wasm-builder-in-no-std branch March 20, 2023 08:53
ordian added a commit that referenced this pull request Mar 21, 2023
* master:
  Companion for #13624 (#2354)
  Introduce Fellowship into Collectives (#2186)
  NFTs 2.0 on Statemine (#2314)
  Bump assert_cmd from 2.0.8 to 2.0.10 (#2341)
  Bump clap from 4.1.8 to 4.1.11 (#2352)
  Companion for substrate #13312: Rename `Deterministic` to `Enforce` (#2350)
  [Companion #13634] keystore overhaul (iter) (#2345)
  Revert #2304 (#2349)
  Deprecate Currency: Companion for #12951 (#2334)
  Bump ci-linux image for rust 1.68
  Always pass port to jsonrpsee WebSocket client (#2339)
  bump zombienet to v1.3.40 (#2348)
  Improve build times by disabling wasm-builder in `no_std` (#2308)
  Bump toml from 0.7.2 to 0.7.3 (#2340)
  Bump serde from 1.0.152 to 1.0.156 (#2329)
  Parachains should charge for proof size weight (#2326)
  dmp-queue: Store messages if already processed more than the maximum (#2343)
  [Companion  #13615] Keystore overhaul (#2336)
  Bump quote from 1.0.23 to 1.0.26 (#2331)
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request May 22, 2023
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request May 23, 2023
* Remove `account`

* Update and companions

* Companion of paritytech/cumulus#2164

* Companion of paritytech/substrate#13159

* Companion of paritytech/cumulus#1909

* Fmt

* Companion of paritytech/polkadot#6744

* Companion of paritytech/cumulus#2245

* Companion of paritytech/substrate#12828

* Companion of paritytech/cumulus#2287

* Companion of paritytech/substrate#13592

* Companion of paritytech/cumulus#2308

* Companion of paritytech/substrate#13410

* Companion of paritytech/substrate#13305

* Companion of polkadot-evm/frontier#1050

* TODO weight

* TODO weight

* Companion of polkadot-evm/frontier#1040

Signed-off-by: Xavier Lau <[email protected]>

* Remove unused dep

* Try fix dev node paritytech/substrate#12828

* Fix the frontier part (#1154)

* Fix dev node

* Fmt

* Bump moonbeam

* Bump moonbeam

* Remove unnecessary clone

* Fix tests

---------

Signed-off-by: Xavier Lau <[email protected]>
Co-authored-by: Guantong <[email protected]>
Co-authored-by: bear <[email protected]>
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants