Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage node key operations using subkey #168

Closed
PierreBesson opened this issue Oct 4, 2022 · 2 comments
Closed

Manage node key operations using subkey #168

PierreBesson opened this issue Oct 4, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers P3 R-testnets

Comments

@PierreBesson
Copy link
Contributor

As pointed out in this discussion, the node key commands might not always be available on node binaries, we should switch to using the parity/subkey:latest docker image.

@BulatSaif
Copy link
Contributor

we also have inject-keys initcontainer with {{ $.Values.node.command }} key insert command, it also will fail if node key command is not available.

@PierreBesson
Copy link
Contributor Author

PierreBesson commented Sep 15, 2023

Since inject-keys uses the node key insert subcommand not available in subkey, it's not possible to replace all instances of node key by subkey. So as we strictly depend on the node key` subcommand being available it's not a good idea to add an additional dependency on the subkey docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P3 R-testnets
Projects
None yet
Development

No branches or pull requests

2 participants