Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old fields in QueueConfigData #1795

Closed
ggwpez opened this issue Oct 5, 2023 · 0 comments · Fixed by #2142
Closed

Cleanup old fields in QueueConfigData #1795

ggwpez opened this issue Oct 5, 2023 · 0 comments · Fixed by #2142
Assignees
@serban300
Labels
T15-bridges This PR/Issue is related to bridges.

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 5, 2023

#1246 introduces deprecates some fields in QueueConfigData that are no longer needed.
As followup to that we should create a migration that removes these fields and translates the struct.
Additionally we should bump the *_threshold fields to be at-least their default values (as defined here).
@ggwpez ggwpez added T8-parachains_engineering T15-bridges This PR/Issue is related to bridges. labels Oct 5, 2023
@serban300 serban300 mentioned this issue Oct 10, 2023
Closed
@serban300 serban300 mentioned this issue Nov 3, 2023
Merged
serban300 added a commit that referenced this issue Dec 4, 2023
@serban300
Cleanup XCMP QueueConfigData (#2142)
1266de3 
Removes obsolete fields from the `QueueConfigData` structure. For the
remaining fields, if they use the old defaults, we replace them with the
new defaults.

Resolves: #1795
juangirini pushed a commit that referenced this issue Dec 4, 2023
@serban300 @juangirini
Cleanup XCMP QueueConfigData (#2142)
14b7132 
Removes obsolete fields from the `QueueConfigData` structure. For the
remaining fields, if they use the old defaults, we replace them with the
new defaults.

Resolves: #1795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serban300 serban300

Labels
T15-bridges This PR/Issue is related to bridges.
Projects
parachains team board
Status: Completed
Milestone
No milestone
3 participants
@ggwpez @serban300 @the-right-joyce