assert_expected_events! gives false positives on inner enum values

[0xmovses]

Is there an existing issue?

• I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

• This is not a support question.

Description of bug

In XCM emulator tests, when asserting on inner Event enum values, the macro will always pass even if the assertion should fail. For example:

assert_expected_events!(
	PeopleRococo,
	vec![
		RuntimeEvent::Balances(pallet_balances::Event::Endowed { account, free_balance }) => {
		    account: *account == PeopleRococoSender::get(),
		    free_balance: *free_balance == 42,
		    },
		]
);

No matter what number you assert free_balance, it will always pass (if the event is emitted).

*free_balance == 42,
*free_balance == 10000,
*free_balance == 234598,

These will all pass. We don't want false positives on XCM emulator tests for obvious reasons.

Steps to reproduce

1. On master, navigate to cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-rococo/src/tests/send.rs

2. On line 90 you'll see an assertion :

assert_expected_events!(
			AssetHubRococo,
			vec![
				RuntimeEvent::Assets(pallet_assets::Event::Burned { asset_id, owner, balance }) => {
					asset_id: *asset_id == ASSET_ID,
					owner: *owner == para_sovereign_account,
					balance: *balance == fee_amount,
				},

3. Change the value of ASSET_ID to some other number, re-run the test. The test still passes

[joepetrowski]

Steps to reproduce

Can you add a reproducible example on its own that's not dependent on a branch? E.g.

#[test]
fn inner_event_assertions_should_work() {
	RococoRelay::execute_with(|| {
		type RuntimeEvent = <RococoRelay as Chain>::RuntimeEvent;

		assert_ok!(/* balance transfer */);
		assert_expected_events!(
			RococoRelay,
			vec![
				RuntimeEvent::Balances(pallet_balances::Event::Transfer { from, to, amount }) => {
					/* assert things */
				},
			]
		);
	});
}

[bkontur]

could this be related to this: #1127 ?

[0xmovses]

@joepetrowski I've updated the issue with an example that can be ran on main.