Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate how to store pending responses in ChainSync efficiently #510

Open
altonen opened this issue Apr 20, 2023 · 0 comments
Open

Investigate how to store pending responses in ChainSync efficiently #510

altonen opened this issue Apr 20, 2023 · 0 comments
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.

Comments

@altonen
Copy link
Contributor

altonen commented Apr 20, 2023 

          Just a thought, this hashmap will be iterated quite often. Maybe it's worth looking at [indexmap](https://docs.rs/indexmap/latest/indexmap/)  for iteration performance? But I am not sure how many elements there are typically in `pending_responses`, so maybe this is a premature optimization.

Originally posted by @skunert in paritytech/substrate#13941 (comment)
@altonen altonen mentioned this issue Apr 20, 2023
Merged
@altonen altonen added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. I7-refactor labels Apr 20, 2023
@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed I7-refactor labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
Networking
Status: Backlog 🗒
Milestone
No milestone
Development

No branches or pull requests
2 participants
@altonen @the-right-joyce