Expiry time for MultiSig calls #1281

Szegoo · 2023-08-29T19:23:28Z

Introduces:

a new storage map: MultisigExpiries
create_multisig_with_expiry extrinsic for creating a multisig that has a specified expiry.
updates the operate function to check whether the multisig has expired.

TODO:

Update the NewMultisig event to include a field for expiry
Add the clear_expired_multi
Write tests
Benchmark the clear_expired_multi extrinsic
Calculate the weight for the clear_expired_multi extrinsic.

This PR is migrated from the Substrate repo.
The original PR: paritytech/substrate#14444

Closes: #231

Szegoo · 2023-08-29T19:25:11Z

@liamaharon Would be great if you could review my PR here, I added the try-state test you mentioned, so everything should be good now.

juangirini · 2023-08-30T09:30:52Z

substrate/frame/multisig/src/lib.rs

 )
 }

+ /// DEPRECATED: Use the `approve_as_multi` extrinsic instead.


Suggested change

/// DEPRECATED: Use the `approve_as_multi` extrinsic instead.

/// DEPRECATED: Use the `approve_as_multi` extrinsic instead.

/// It will be removed after March 2024.

I haven't looked at the entire PR but if this is moving forward we need to create a 'deprecation' issue just like this one #147 (following the process described here #182)

From my understanding after reading the description of #182, shouldn't this be a note inside the deprecated attribute macro instead of a plain comment?

True, that would help if a call to that function is compiled by Rust, which most likely would happen within a test.
Most of the cases the dispatchable function would be called by external Builders, in that case there isn't much we can do at the moment, please see #182 (comment)

substrate/frame/multisig/src/lib.rs

substrate/frame/multisig/src/tests.rs

liamaharon · 2023-08-31T01:23:46Z

This is getting close to completion. @ggwpez the multisig pallet is especially sensitive so I'm guessing needs an audit? Do you know how to request an srlabs review?

substrate/frame/multisig/src/lib.rs

Co-authored-by: Liam Aharon <[email protected]>

Co-authored-by: Juan <[email protected]>

substrate/frame/multisig/src/lib.rs

Co-authored-by: Francisco Aguirre <[email protected]>

command-bot · 2023-10-17T07:28:48Z

@liamaharon https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979984 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=contracts-rococo --runtime_dir=contracts --target_dir=cumulus --pallet=pallet_multisig. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 56-e95cd800-10bf-4dca-857e-bf7aa8ed3308 to cancel this command or bot cancel to cancel all commands in this pull request.

…e=westend --target_dir=polkadot --pallet=pallet_multisig

command-bot · 2023-10-17T08:07:05Z

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=westend --target_dir=polkadot --pallet=pallet_multisig has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979980 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979980/artifacts/download.

command-bot · 2023-10-17T08:07:12Z

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_multisig has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979977 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979977/artifacts/download.

command-bot · 2023-10-17T08:46:56Z

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=contracts-rococo --runtime_dir=contracts --target_dir=cumulus --pallet=pallet_multisig has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979984 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979984/artifacts/download.

command-bot · 2023-10-17T08:48:18Z

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_multisig has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979981 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979981/artifacts/download.

command-bot · 2023-10-17T08:48:41Z

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_multisig has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979982 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3979982/artifacts/download.

paritytech-cicd-pr · 2023-11-13T18:59:45Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4314279

…n library (paritytech#1281)

…n library (#1281)

bkchr · 2024-07-17T12:29:32Z

@Szegoo do you still want to land this pr? If yes, please update and then we need to find some reviewers.

Szegoo and others added 2 commits August 29, 2023 21:18

Expiry time for MultiSig calls

be96656

Merge branch 'master' into multisig-expiry

0d8a934

paritytech-ci requested a review from a team August 29, 2023 19:24

liamaharon self-requested a review August 30, 2023 01:16

liamaharon added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Aug 30, 2023

juangirini reviewed Aug 30, 2023

View reviewed changes

paritytech-ci requested a review from a team August 30, 2023 09:32

liamaharon reviewed Aug 31, 2023

View reviewed changes

paritytech-ci requested a review from a team August 31, 2023 01:23

xlc reviewed Aug 31, 2023

View reviewed changes

substrate/frame/multisig/src/lib.rs Outdated Show resolved Hide resolved

Szegoo and others added 13 commits August 31, 2023 07:42

Update substrate/frame/multisig/src/lib.rs

ec70023

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/lib.rs

07dec63

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/lib.rs

9a1a619

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/lib.rs

cf140f0

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/lib.rs

6882821

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/lib.rs

5a99f94

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/lib.rs

8667b20

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/lib.rs

76cf971

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/tests.rs

9ea8802

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/tests.rs

ceb81f1

Co-authored-by: Liam Aharon <[email protected]>

Update substrate/frame/multisig/src/lib.rs

c3da879

Co-authored-by: Liam Aharon <[email protected]>

update MultisigCancelled event & update complexity

5151675

Update substrate/frame/multisig/src/lib.rs

c4350c1

Co-authored-by: Juan <[email protected]>

Szegoo force-pushed the multisig-expiry branch from 8a0cdb5 to c4350c1 Compare September 4, 2023 20:28

Merge branch 'master' into multisig-expiry

ddf7291

franciscoaguirre reviewed Sep 4, 2023

View reviewed changes

substrate/frame/multisig/src/lib.rs Outdated Show resolved Hide resolved

substrate/frame/multisig/src/lib.rs Outdated Show resolved Hide resolved

substrate/frame/multisig/src/lib.rs Show resolved Hide resolved

paritytech-ci requested a review from a team September 4, 2023 20:45

Update substrate/frame/multisig/src/lib.rs

6bc178e

Co-authored-by: Francisco Aguirre <[email protected]>

".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtim…

9782b4f

…e=westend --target_dir=polkadot --pallet=pallet_multisig

fix warning

7b28274

Merge branch 'master' into multisig-expiry

a2b7c9c

paritytech-review-bot bot requested a review from a team November 13, 2023 12:40

fix

2970d27

warning fix

44b3372

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

089edd1

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

264f3e4

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

f86df3d

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

1844d69

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

b8858e7

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

61aa5fc

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

79c81ce

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

e8f7e2a

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

bebf2f4

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

fc9ed77

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

3c4b136

…n library (paritytech#1281)

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

3d3f58c

…n library (paritytech#1281)

bkchr pushed a commit that referenced this pull request Apr 10, 2024

move "common" code of messages pallet benchmarks helpers to the commo…

fd816b6

…n library (#1281)

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

balqaasem mentioned this pull request Jul 28, 2024

🎉 Wishlist: Users Setheum-Labs/Setheum#1066

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expiry time for MultiSig calls #1281

Expiry time for MultiSig calls #1281

Szegoo commented Aug 29, 2023 •

edited

Loading

Szegoo commented Aug 29, 2023

juangirini Aug 30, 2023

Szegoo Sep 2, 2023

juangirini Sep 4, 2023

liamaharon commented Aug 31, 2023

command-bot bot commented Oct 17, 2023 •

edited

Loading

command-bot bot commented Oct 17, 2023

command-bot bot commented Oct 17, 2023

command-bot bot commented Oct 17, 2023

command-bot bot commented Oct 17, 2023

command-bot bot commented Oct 17, 2023

paritytech-cicd-pr commented Nov 13, 2023

bkchr commented Jul 17, 2024

	/// DEPRECATED: Use the `approve_as_multi` extrinsic instead.
	/// DEPRECATED: Use the `approve_as_multi` extrinsic instead.
	/// It will be removed after March 2024.

Expiry time for MultiSig calls #1281

Are you sure you want to change the base?

Expiry time for MultiSig calls #1281

Conversation

Szegoo commented Aug 29, 2023 • edited Loading

Szegoo commented Aug 29, 2023

juangirini Aug 30, 2023

Choose a reason for hiding this comment

Szegoo Sep 2, 2023

Choose a reason for hiding this comment

juangirini Sep 4, 2023

Choose a reason for hiding this comment

liamaharon commented Aug 31, 2023

command-bot bot commented Oct 17, 2023 • edited Loading

command-bot bot commented Oct 17, 2023

command-bot bot commented Oct 17, 2023

command-bot bot commented Oct 17, 2023

command-bot bot commented Oct 17, 2023

command-bot bot commented Oct 17, 2023

paritytech-cicd-pr commented Nov 13, 2023

bkchr commented Jul 17, 2024

Szegoo commented Aug 29, 2023 •

edited

Loading

command-bot bot commented Oct 17, 2023 •

edited

Loading