upgrade to macro_magic 0.5.0 #1832
Conversation
sam0x17
added
R0-silent
|
macro_magic 0.4.3 should be yanked from crates.io, I can't compile runtimes anymore because runtime compilation doesn't have lock file and this new release essentially breaks all downstram builds for the ecosystem. Please honor semver. |
|
Yeah sorry about that all didn't intend for the core/internal functions to be part of the public API (and therefore semver exempt) but our usage of them in substrate has basically forced them to be part of the public API so here we are lol. 0.4.3 has been yanked and re-published as 0.5.0. That said, if our versions are locked properly across polkadot-sdk, this shouldn't be an issue, as any inadvertent minor update can be a supply chain attack, so wanted to flag that... |
|
I just wiped |
might have to clear cargo cache |
I did, that was the problem (while 0.4.3 was still published). This is to the point of lock file being non-existant when WASM version of the runtime is compiled. |
|
I previously believed that a line like This means there are many places in polkadot-sdk where we have third party deps that could easily be subject to supply chain attacks, so opening an issue for that ASAP |
|
cc @gupnik it's now |
* master: (33 commits) ci: set CI_IMAGE back to (now updated) .ci-unified (#1854) ci: bump ci image to rust 1.73.0 (#1830) Refactor Identity to benchmark v2 (#1838) PVF worker: bump landlock, update ABI docs (#1850) Xcm emulator nits (#1649) Fixes path issue in derive-impl (#1823) upgrade to macro_magic 0.4.3 (#1832) Use safe math when pruning statuses (#1835) remote-ext: fix state download stall on slow connections and reduce memory usage (#1295) Update testnet bootnode dns name (#1712) [FRAME] Warn on unchecked weight witness (#1818) [xcm] Use `Weight::MAX` for `reserve_asset_deposited`, `receive_teleported_asset` benchmarks (#1726) Update bridges subtree (#1803) Check for parent of first ready block being on chain (#1812) Make CheckNonce refuse transactions signed by accounts with no providers (#1578) Fix Asset Hub collator crashing when starting from genesis (#1788) Mixnet integration (#1346) [xcm-emulator] Decouple the `AccountId` type from `AccountId32` (#1458) Treasury spends various asset kinds (#1333) chore: bump zombienter version (#1806) ...
# Description Upgrades `macro_magic` to 0.4.3, which introduces the ability to have `export_tokens` use the same name as the underlying item for its auto-generated macro name. Ultimately this will allow for better dev ux in our derive_impl feature.
* verify partial repo build on CI * try with "git checkout ." * no-revert * use no-revert on CI * fix for use in Cumulus repo * move to nightly * move desc * rename script * actual rename
Description
Upgrades
macro_magicto0.4.30.5.0, which introduces the ability to haveexport_tokensuse the same name as the underlying item for its auto-generated macro name. Ultimately this will allow for better dev ux in our derive_impl feature.