Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testnet] BridgeHubRococo nits #1972

Merged
merged 15 commits into from
Oct 23, 2023
Merged

[testnet] BridgeHubRococo nits #1972

merged 15 commits into from
Oct 23, 2023

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Oct 22, 2023

This PR does not introduce any functional changes to the existing code, it merely addresses several minor refactors:

  • Moving bridging pallets to separate files.
  • Improving the readability and naming of weight files for bridging pallets and bridging pallet instances.

The reason for this refactor is to facilitate easier plugin integration for the upcoming bridge between Rococo and Westend.

@bkontur bkontur added the T9-cumulus This PR/Issue is related to cumulus. label Oct 22, 2023
@bkontur bkontur enabled auto-merge (squash) October 22, 2023 09:29
@bkontur bkontur disabled auto-merge October 22, 2023 09:29
@bkontur
Copy link
Contributor Author

bkontur commented Oct 22, 2023

bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_grandpa
bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_parachains
bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_messages
bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_relayers

@bkontur
Copy link
Contributor Author

bkontur commented Oct 22, 2023

bot bench -v CMD_IMAGE=ci-unified:bullseye-1.73.0-2023-05-23-v20231009 cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_grandpa

@bkontur
Copy link
Contributor Author

bkontur commented Oct 22, 2023

bot bench -v CMD_IMAGE=ci-unified:paritytech/bullseye-1.73.0-2023-05-23-v20231009 --runtime=bridge-hub-rococo --pallet=pallet_bridge_grandpa

@bkontur
Copy link
Contributor Author

bkontur commented Oct 22, 2023

bot bench -v CMD_IMAGE="ci-unified:paritytech/bullseye-1.73.0-2023-05-23-v20231009" --runtime=bridge-hub-rococo --pallet=pallet_bridge_grandpa

@bkontur
Copy link
Contributor Author

bkontur commented Oct 22, 2023

bot bench -v CMD_IMAGE=paritytech/bullseye-1.73.0-2023-05-23-v20231009 --runtime=bridge-hub-rococo --pallet=pallet_bridge_grandpa

@bkontur
Copy link
Contributor Author

bkontur commented Oct 22, 2023

bot bench -v CMD_IMAGE=paritytech/ci-unified:bullseye-1.73.0-2023-05-23-v20231009 --runtime=bridge-hub-rococo --pallet=pallet_bridge_grandpa

@bkontur
Copy link
Contributor Author

bkontur commented Oct 22, 2023

bot bench -v CMD_IMAGE=paritytech/ci-unified:bullseye-1.73.0-2023-05-23-v20231009 cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_grandpa

@bkontur
Copy link
Contributor Author

bkontur commented Oct 22, 2023

bot clean

@bkontur
Copy link
Contributor Author

bkontur commented Oct 22, 2023

bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_grandpa
bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_parachains
bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_messages
bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_relayers

@command-bot
Copy link

command-bot bot commented Oct 22, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040958 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 20-a7a00360-6795-4ecf-a1b6-edb13fad3dbd to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 22, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040959 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_parachains. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 21-424a95ea-2ded-4b13-aae3-0aa4215481f1 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 22, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040960 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 22-f80de5c7-ba92-49ba-bfec-efcf11d14297 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 22, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040961 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 23-6da8049e-ca61-4539-8a9f-8a8c73009f52 to cancel this command or bot cancel to cancel all commands in this pull request.

…=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers
@command-bot
Copy link

command-bot bot commented Oct 22, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040961 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040961/artifacts/download.

@command-bot
Copy link

command-bot bot commented Oct 22, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_parachains has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040959 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040959/artifacts/download.

@command-bot
Copy link

command-bot bot commented Oct 22, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040960 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040960/artifacts/download.

@command-bot
Copy link

command-bot bot commented Oct 22, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040958 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4040958/artifacts/download.

@acatangiu acatangiu requested a review from a team October 23, 2023 07:41
@bkontur bkontur enabled auto-merge (squash) October 23, 2023 10:46
@bkontur bkontur merged commit e0620fd into master Oct 23, 2023
110 of 111 checks passed
@bkontur bkontur deleted the bko-bridge-hub-nits branch October 23, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants