Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Chain API subsystem #1498

Merged
24 commits merged into from
Jul 31, 2020
Merged

Chain API subsystem #1498

24 commits merged into from
Jul 31, 2020

Conversation

ordian
Copy link
Member

@ordian ordian commented Jul 29, 2020 •
edited
Loading

Fixes #1415.
Fixes #1416.

  • ancestry request
  • convert return types to Result
  • guide

@ordian ordian added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 29, 2020
@rphmeier
Copy link
Contributor

I know this is in-progress. This should close #1415 also, and add a small page detailing the workings of the subsystem.

ordian added 10 commits July 30, 2020 13:05
@ordian
chain-api subsystem: mock testclient
1ae33cf
@ordian
chain-api subsystem: impl HeaderBacked for TestClient
154a65e
@ordian
chain-api subsystem: impl basic tests
9257f4a
@ordian
chain-api subsystem: tiny guide
eccd0cb
@ordian
chain-api subsystem: rename ChainApiRequestMessage to ChainApiMessage
4e66d5c
@ordian
chain-api subsystem: add the page to the ToC
ced5547
@ordian
chain-api subsystem: proper error type
7d822fb
@ordian
Merge branch 'master' into ao-chain-api-subsystem
a5b0913 
* master:
  Candidate Validation Subsystem (#1432)
  reduce slash defer durations (#1504)
  Implement the Runtime API subsystem (#1494)
  Companion for #6610 (Balances Weight Trait) (#1425)
  [CI] Publish draft release redux (#1493)
  Update README docs related to local build (#1479)
  Add a default trie-memory-tracker feature to the cli (#1502)
  Companion PR for `Add a `DefaultQueue` type alias to remove the need to use `sp_api::TransactionFor`` (#1499)
  Fix bitfield signing (#1466)
  Update Substrate, bump versions, clean up sort (#1496)
  Bump Substrate
@ordian
chain-api subsystem: impl ancestors request
97b711a
@ordian
chain-api subsystem: tests for ancestors request
5b49bce
@ordian ordian marked this pull request as ready for review July 31, 2020 12:20
@ordian ordian requested a review from drahnr July 31, 2020 12:20
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jul 31, 2020
drahnr
drahnr approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your open questions should be resolved before merging, the existing code looks good to me 👍

@ordian ordian requested a review from rphmeier July 31, 2020 15:06
@ordian
Merge branch 'master' into ao-chain-api-subsystem
b0e21ba 
* master:
  guide: collator networking & subsystems (#1452)
  Guide: add a diagram for Inclusion Pipeline & Approval Subsystem (#1457)
  [CI] Build wasm blob with srtool and include prop hashes and blobs in release notes (#1506)
rphmeier
rphmeier approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a merge with master, LGTM

@ordian
Copy link
Member Author

ordian commented Jul 31, 2020

bot merge

@ghost
Copy link

ghost commented Jul 31, 2020

Waiting for commit status.

@ordian
Copy link
Member Author

ordian commented Jul 31, 2020

re FinalizedBlockHash, I went with

/// Note: the caller must ensure the block is finalized.

we should reconsider if this approach is problematic

@ghost
Copy link

ghost commented Jul 31, 2020

Checks failed; merge aborted.

@ordian
Copy link
Member Author

ordian commented Jul 31, 2020

bot merge

@ghost
Copy link

ghost commented Jul 31, 2020

Waiting for commit status.

@ghost ghost merged commit d402263 into master Jul 31, 2020
@ghost ghost deleted the ao-chain-api-subsystem branch July 31, 2020 16:02
@ordian ordian mentioned this pull request Aug 3, 2020
Merged
@ordian ordian mentioned this pull request Sep 27, 2022
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drahnr drahnr drahnr approved these changes

@rphmeier rphmeier rphmeier approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Chain API Subsystem Guide: Chain API Subsystem
3 participants
@ordian @rphmeier @drahnr