Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Actually connect to new validators at session boundary. #3055

Merged
2 commits merged into from
May 19, 2021
Merged

Actually connect to new validators at session boundary. #3055

2 commits merged into from
May 19, 2021

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented May 19, 2021

No description provided.

@eskimor eskimor added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 19, 2021
ordian
ordian approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, good catch!

@andresilva
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented May 19, 2021

Waiting for commit status.

@ordian ordian mentioned this pull request May 19, 2021
Merged
@ghost
Copy link

ghost commented May 19, 2021

Merge aborted: Head SHA changed from fe8a53c to d0b6766

@ordian ordian added this to the release v0.9.2 milestone May 19, 2021
@ordian
Copy link
Member

ordian commented May 19, 2021

bot merge

@ghost
Copy link

ghost commented May 19, 2021

Waiting for commit status.

@andresilva
Copy link
Contributor

Can we add tracing here as well? Unless it's totally not relevant.

@ordian
Copy link
Member

ordian commented May 19, 2021

Can we add tracing here as well? Unless it's totally not relevant.

that's going to be removed in #3052, because it's a subset of what we're requesting in gossip-support, so it doesn't really provide a value

@andresilva
Copy link
Contributor

Yeah, it's only the validators from our group.

@ghost ghost merged commit 9fd0f5b into master May 19, 2021
@ghost ghost deleted the rk-fix-validator-connection branch May 19, 2021 11:29
andresilva pushed a commit that referenced this pull request May 19, 2021
@eskimor @andresilva
Actually connect to new validators at session boundary. (#3055)
ab48a31 
* Actually connect to new validators at session boundary.

* Add tracing.
andresilva pushed a commit that referenced this pull request May 19, 2021
@eskimor @andresilva
Actually connect to new validators at session boundary. (#3055)
93c76bb 
* Actually connect to new validators at session boundary.

* Add tracing.
ordian added a commit that referenced this pull request May 19, 2021
@ordian
Merge branch 'master' into ao-alternative-validator-discovery-design
9d69bf8 
* master:
  Actually connect to new validators at session boundary. (#3055)
  Register ReadRuntimeVersionExt (#3045)
  Bump version & spec version in prep for v0.9.2 (#3046)
  Remove host configuration set migration from Kusama & Westend (#3050)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
release v0.9.2
Development

Successfully merging this pull request may close these issues.
3 participants
@eskimor @andresilva @ordian