This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for #10808 (Transactional Layer Limit) #5232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
approved these changes
Apr 2, 2022
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for 7c7f098 |
ggwpez
added
B0-silent
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#10808
The
with_transactionalused inside theparas_inherentdoes not seem trivial to return an error.This we are using the
uncheckedmethod here for backwards compatibility. Would be best to update this in the future if possible cc @drahnr