Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to request reviewers #97

Merged
merged 11 commits into from
Oct 30, 2023
Merged

Conversation

Bullrich
Copy link
Collaborator

@Bullrich Bullrich commented Oct 30, 2023

Added the feature to request reviewers. For this we are using a github app with pull request write permission (I need to request our app to be updated).

I will be making a following PR to merge the keys as we are using the same key for all the github classes.

The request feature is disabled by default.

Resolves #53

@Bullrich Bullrich requested a review from a team as a code owner October 30, 2023 14:24
@Bullrich Bullrich self-assigned this Oct 30, 2023
README.md Outdated Show resolved Hide resolved
@Bullrich Bullrich merged commit cb282c9 into main Oct 30, 2023
11 checks passed
@Bullrich Bullrich deleted the bullrich/request-reviewers branch October 30, 2023 15:56
@Bullrich Bullrich mentioned this pull request Oct 31, 2023
Bullrich added a commit that referenced this pull request Oct 31, 2023
This version includes the fix for #53 in #97
Bullrich added a commit to paritytech/polkadot-sdk that referenced this pull request Oct 31, 2023
This version includes paritytech/review-bot#97 which can assign reviewers.

It will be the final replacement for PRCR.

It also moves the secrets to the environment master.
Bullrich added a commit to paritytech/polkadot-sdk that referenced this pull request Nov 1, 2023
This version includes paritytech/review-bot#97 which can assign
reviewers.

It will be the final step required to replace PRCR.

It also moves the secrets to the environment master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign reviewers
2 participants