Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

The identity module use "Sudo" prefix incorrectly #4591

Closed
gui1117 opened this issue Jan 10, 2020 · 3 comments · Fixed by #5010
Closed

The identity module use "Sudo" prefix incorrectly #4591

gui1117 opened this issue Jan 10, 2020 · 3 comments · Fixed by #5010

Comments

@gui1117
Copy link
Contributor

gui1117 commented Jan 10, 2020

the prefix used by identity is "Sudo"

trait Store for Module<T: Trait> as Sudo {

this is probably not intented and might leads to collision with sudo module, however fixing it require migrating Kusama identity module.

@kianenigma
Copy link
Contributor

Yeah; I saw this while scraping some data a while back and I hoped it was intentional in some way? I forgot to ask but I could see the author actually wanting to place them under the same tree path for some optimisation reasons?

@shawntabrizi
Copy link
Member

shawntabrizi commented Jan 12, 2020

No, this is likely copy paste issue.

@thiolliere is it possible to make this string come from the construct_runtime! macro? Or maybe more simply, we could take advantage of the ModuleToIndex trait that was introduced for decl_error

@bkchr
Copy link
Member

bkchr commented Jan 12, 2020

We can not use ModuleToIndex for this, as it would break in the moment you insert a module in between. However, we probably could support this in construct runtime (by just taking the name that the user chooses), but this is a really huge change and requires a storage upgrade. So, nothing that will come in the near future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants