You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Due to the limitation of current transactional overlay storage, it is recommended to not have too many nested with_transaction calls #6269 (comment).
So we end up many calls that have rollback after storage modification, expected to only be called within with_transaction.
Currently the only way to ensure those calls are used correctly is manual review, which are error-prone.
I would like to suggest a #[require_transactional] annotation, on release build, does nothing, but on debug std build / unit test, assert it is called within with_transaction.
The text was updated successfully, but these errors were encountered:
Due to the limitation of current transactional overlay storage, it is recommended to not have too many nested
with_transaction
calls #6269 (comment).So we end up many calls that have rollback after storage modification, expected to only be called within
with_transaction
.Currently the only way to ensure those calls are used correctly is manual review, which are error-prone.
I would like to suggest a
#[require_transactional]
annotation, on release build, does nothing, but on debug std build / unit test, assert it is called withinwith_transaction
.The text was updated successfully, but these errors were encountered: