This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
fix: regression of sync_state_genSyncSpec #11435
#11437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
added
B0-silent
tomaka
approved these changes
May 17, 2022
dvdplm
approved these changes
May 17, 2022
There was a problem hiding this comment.
This used to be an unsafe RPC in the original PR – did we miss that or was it marked as safe at some later point?
chevdor
approved these changes
May 17, 2022
coderobe
approved these changes
May 17, 2022
niklasad1
changed the title
system_gen_sync_spec #11435sync_state_genSyncSpec #11435
kianenigma
approved these changes
May 17, 2022
tomaka
reviewed
May 17, 2022
tomaka
dismissed
their stale review
Dismissing my review because I'm ask and I don't want to block this PR, but my review comment still stands
dvdplm
suggested changes
May 17, 2022
dvdplm
suggested changes
May 17, 2022
tomaka
approved these changes
May 17, 2022
22 tasks
dvdplm
approved these changes
May 17, 2022
|
bot merge |
chevdor
pushed a commit
that referenced
this pull request
May 17, 2022
* fix: #11435 * address grumbles: better safe than sorry
chevdor
added a commit
that referenced
this pull request
May 18, 2022
* fix: #11435 * address grumbles: better safe than sorry Co-authored-by: Niklas Adolfsson <[email protected]>
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
…ech#11437) * fix: paritytech#11435 * address grumbles: better safe than sorry
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
…ech#11437) * fix: paritytech#11435 * address grumbles: better safe than sorry
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…ech#11437) * fix: paritytech#11435 * address grumbles: better safe than sorry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix regression of system_gen_sync_spec #11435