Extrinsics root is calculated as part of block-building #120

gavofyork · 2018-04-09T14:52:45Z

No description provided.

rphmeier · 2018-04-09T14:59:06Z

substrate/runtime/system/src/lib.rs

@@ -68,6 +75,7 @@ decl_storage! {
 pub BlockHash get(block_hash): b"sys:old" => required map [ T::BlockNumber => T::Hash ];

 pub ExtrinsicIndex get(extrinsic_index): b"sys:xti" => required u32;
+ pub ExtrinsicData get(extrinsic_data): b"sys:xtd" => required map [ u32 => Vec<u8> ];


shouldn't this be cleared in finalise? all the values are taken out of it in derive_extrinsics but is it possible it might leave residuals in storage?

shouldn't be possible.

(with the current map implementation which may be subject to change). It's a bug waiting to happen IMO

it's both notionally and logically impossible. furthermore there's no way of definitively clearing a mapping.

a later PR that (re-)instates an "list" type might be reasonable though.

I don't think it's logically impossible as soon as mappings get any kind of metadata keys (for example, to enable iteration). This is something we will have to watch out for, but not a blocker for this PR.

rphmeier · 2018-04-11T10:15:10Z

polkadot/api/src/lib.rs

@@ -174,7 +177,7 @@ impl<B: Backend> PolkadotApi for Client<B, NativeExecutor<LocalDispatch>>
 fn check_id(&self, id: BlockId) -> Result<CheckedId> {
 // bail if the code is not the same as the natively linked.
 if self.code_at(&id)? != LocalDispatch::native_equivalent() {
- bail!(ErrorKind::UnknownRuntime);
+ warn!("This node is out of date. Block authoring may not work correctly.")


dangerous proposition. I think authorities would prefer to get slashed for being temporarily offline than risk accidentally losing their whole bond.

also means that when we update the runtime, if >2/3 of the authorities have this behavior, they will continue growing the chain with the wrong rules.

(I get why this change is in this PR -- the genesis.wasm is a nuisance to work around, but we should just stop checking this stuff in and have an environment variable for when we want to use a specific runtime wasm!)

to be honest we're going to have to introduce semantic versioning here anyway. it's impractical to ensure that a node is updated, restarted and where necessary migrated at exactly the block boundary when the runtime changes, so there will need to be changeover periods. bailing here is unreasonable.

right, but there are different approaches to that, and given that the API can change between runtimes, it's likely we might do something based on linking multiple versions of the polkadot-api crate. Network, consensus, and other client-level code might change between runtimes as well.

i'd rather just have semantic versioning of the API and be done with it.

can we agree to classify that as beyond the scope of this PR and introduce that later?

demo/runtime/wasm/target/wasm32-unknown-unknown/release/demo_runtime.compact.wasm demo/runtime/wasm/target/wasm32-unknown-unknown/release/demo_runtime.wasm polkadot/runtime/wasm/target/wasm32-unknown-unknown/release/polkadot_runtime.compact.wasm polkadot/runtime/wasm/target/wasm32-unknown-unknown/release/polkadot_runtime.wasm substrate/test-runtime/wasm/target/wasm32-unknown-unknown/release/substrate_test_runtime.compact.wasm substrate/test-runtime/wasm/target/wasm32-unknown-unknown/release/substrate_test_runtime.wasm

arkpar · 2018-04-11T16:07:46Z

What's the reason for downgrading log?

gavofyork · 2018-04-12T09:42:45Z

It was actually never upgraded, and the rest of the codebase relied on a symbol not in 0.4.

* Fixes workflow draft release & Adds doc * Fixes draft conditions

* change pendingorders orderpair {first, second, precision} => {first, second} * format code and modify test

* Split out cli crate * Rearrange the deps alphabetically * https * Add crates to workspace memembers * ChainX runtime should require unwinding too * . * Nits * Reorg assets-runtim-api crate Should be organized as follows: assets/ rpc/ runtime-api/ Cargo.toml Cargo.toml Cargo.toml

…signature Derive local challenge from signature instead of public key hash

* Fix optional store items. * Support querying a block hash.

extrinsics root is calculated as part of block-building.

12a3235

gavofyork added the A0-please_review Pull request needs code review. label Apr 9, 2018

rphmeier reviewed Apr 9, 2018

View reviewed changes

gavofyork added 2 commits April 9, 2018 18:14

Fix build.

2df8297

Fix xt root.

a5d5d46

rphmeier mentioned this pull request Apr 10, 2018

kill post_finalise #121

Merged

gavofyork added 2 commits April 10, 2018 22:47

Couple of fixes.

0ebfccf

Logging and more useful APIs.

3624417

rphmeier reviewed Apr 11, 2018

View reviewed changes

Fix test.

dd37fec

rphmeier added A5-grumble and removed A0-please_review Pull request needs code review. labels Apr 11, 2018

gavofyork added 2 commits April 11, 2018 16:10

Update log version.

01a55d4

gavofyork added A0-please_review Pull request needs code review. and removed A5-grumble labels Apr 11, 2018

gavofyork added 2 commits April 11, 2018 16:53

Merge branch 'master' into gav-runtime-xts

bed4492

Switch back to correct version of log.

39d0ddf

Merge branch 'master' into gav-runtime-xts

0b929de

rphmeier approved these changes Apr 12, 2018

View reviewed changes

rphmeier merged commit 5199bc1 into master Apr 12, 2018

gavofyork deleted the gav-runtime-xts branch April 12, 2018 10:19

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020

Update to latest substrate (paritytech#120)

69937fd

JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this pull request Apr 21, 2021

Fixes workflow draft release & Adds doc (paritytech#120)

8c15733

* Fixes workflow draft release & Adds doc * Fixes draft conditions

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021

refactor pendingorders orderpair key type (paritytech#120)

9c6bdc1

* change pendingorders orderpair {first, second, precision} => {first, second} * format code and modify test

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022

Merge pull request paritytech#120 from subspace/local-challenge-from-…

fac541c

…signature Derive local challenge from signature instead of public key hash

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023

Fix optional store items. (paritytech#120)

26ada75

* Fix optional store items. * Support querying a block hash.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extrinsics root is calculated as part of block-building #120

Extrinsics root is calculated as part of block-building #120

gavofyork commented Apr 9, 2018

rphmeier Apr 9, 2018 •

edited

Loading

gavofyork Apr 10, 2018

rphmeier Apr 10, 2018 •

edited

Loading

gavofyork Apr 10, 2018

gavofyork Apr 10, 2018

rphmeier Apr 11, 2018 •

edited

Loading

rphmeier Apr 11, 2018

rphmeier Apr 11, 2018

gavofyork Apr 11, 2018

rphmeier Apr 11, 2018 •

edited

Loading

gavofyork Apr 11, 2018

rphmeier Apr 11, 2018

gavofyork Apr 11, 2018

arkpar commented Apr 11, 2018

gavofyork commented Apr 12, 2018

Extrinsics root is calculated as part of block-building #120

Extrinsics root is calculated as part of block-building #120

Conversation

gavofyork commented Apr 9, 2018

rphmeier Apr 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rphmeier Apr 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rphmeier Apr 11, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rphmeier Apr 11, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arkpar commented Apr 11, 2018

gavofyork commented Apr 12, 2018

rphmeier Apr 9, 2018 •

edited

Loading

rphmeier Apr 10, 2018 •

edited

Loading

rphmeier Apr 11, 2018 •

edited

Loading

rphmeier Apr 11, 2018 •

edited

Loading