This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
FRAME: Fix the Referenda confirming alarm #13704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing a straight
mul
to get the block number from aPerbill
, which will round down if the fractional part is half or less. We should always be rounding up, though, to ensure that when the alarm goes off the confirmation period is definitely ready to begin.It would be good to write a fuzzer to ensure the issue manifested itself prior and no longer manifests after these changes. It is also possible that the issue was fixed by #13660, so if a fuzzer doesn't find this has fixed anything we might want to try testing with the commit immediately before.
Possible fix for paritytech/polkadot-sdk#200