Storage migration of elections-phragmen #3948

kianenigma · 2019-10-28T18:52:02Z

No description provided.

srml/elections-phragmen/src/lib.rs

kianenigma · 2019-10-28T19:45:36Z

okay -- the test case should be enough for ensure this will do what it is supposed to do; but I would triple check every line of it.

xlc · 2019-10-29T02:56:39Z

srml/elections-phragmen/src/lib.rs

+ /// Has the storage format been updated?
+ /// NOTE: Only use and set to false if you have used an early version of this module. Should
+ /// be set to true otherwise.
+ DidMigrate: bool = false;


should just initialise this to true here? also will it better to use a u8 version byte instead?
upgrade existing chain won't reinitialise this and will have DidMigrate to be None which defaults to false

Good ideas.

no need for version byte. once the upgrade is through, a second update should remove the item from storage, and then all logic as well as the storage item declaration may be removed from code completely.

this process can be repeated whenever necessary and doesn't leave an additional set of storage items around indefinitely.

should be left without default, or as is with = false.

in general we'd want an additional genesis item that set it to true, but setting a default isn't the way to do that.

this code won't live long enough to be worth it, though.

srml/elections-phragmen/src/lib.rs

Co-Authored-By: Bastian Köcher <[email protected]>

kianenigma · 2019-10-29T10:01:28Z

Changed to didMigrate: bool with no default and checking with ::exists().

I saw your PR and I think that's also not that far from being ready. We could merge them together and then do the migration, or take it step by step and do this manually.

srml/elections-phragmen/src/lib.rs

gui1117 · 2019-10-29T14:22:12Z

just a note: we are sure that no other module inside their on_initialize indirectly call a method of election-phragment that use this storage, isn't it ?

(to be more precise no other module that have a higher position in construct_runtime!)

kianenigma · 2019-10-29T14:46:15Z

just a note: we are sure that no other module inside their on_initialize indirectly call on method of election-phragment isn't it ?

(to be more precise no other module that have a higher position in construct_runtime!)

Good point, but not as far as I can reason about.

@kianenigma

# Membership Request Hi, I am Kian Paimani, known as @kianenigma. I have been working on Polkadot/Kusama through Parity since February 2019 and I can categorize my main contributions to Polkadot's ecosystem as follows: 1. Maintaining and developing the staking sub-system. 2. General FRAME development, especially testing and quality assurance. 3. Polkadot-native side-projects. 4. Education > My first contribution to Polkadot is also indeed related to staking: paritytech/substrate#1915 ### Staking system I joke as the Polkadot staking to be both my blessing and my curse over the years. I started working on it since the first days that I joined this ecosystem and the work [is ongoing ever since](https:/orgs/paritytech/projects/33/views/9). In the past, I focused on making sure that the staking system is secure and to some extent scalable. More recently, I coordinated the (imminent) launch of Nomination Pools. Nowadays I also put an extra effort on making sure that this sub-system of Polkadot is *sustainable*, through code refactor and educating other core developers. Lastly, I have been the main author of the [Polkadot staking newsletter](https://gist.github.com/kianenigma/aa835946455b9a3f167821b9d05ba376), which is my main attempt at making the entire complexity and development of this part of the protocol transparent to the end-users. I expect myself to contribute *directly* to the staking system for at least another ~12, if not more, and afterwards having the role of an advisor. Some notable contributions: - paritytech/substrate#4517 - paritytech/substrate#7910 - paritytech/substrate#6242 - paritytech/substrate#9415 - paritytech/polkadot#3141 - paritytech/substrate#11212 - paritytech/substrate#12129 ### FRAME Historically, I have contributed a variety of domains in FRAME, namely: - Early version of the weight system paritytech/substrate#3816 paritytech/substrate#3157 - Early version of the transaction fee system - Primitive arithmetic types paritytech/substrate#3456 - Council election pallet paritytech/substrate#3364 Many of which were, admittedly, a PoC at most, if not considered "poor". I am happy that nowadays many of the above have been refactored and are being maintained by new domain experts. These days, I put most of my FRAME focus on testing and quality assurance. Through my work in the staking system, I have had to deal with the high sensitivity and liveness requirement of protocol development first hand (I believe I had to do among the [very first storage migrations](paritytech/substrate#3948) in Kusama) and consequently I felt the need to make better testing facilities, all of which have been formulated in https://forum.polkadot.network/t/testing-complex-frame-pallets-discussion-tools/356. Some relevant PRs: - paritytech/substrate#8038 - paritytech/substrate#9788 - paritytech/substrate#10174 Regardless of wearing the staking hat, I plan to remain a direct contributor to FRAME, namely because I consider it to be an important requirements of successfully delivering more features to Polkadot's ecosystem. ### Polkadot-Native Side Projects I have started multiple small, mostly non-RUST projects in the polkadot ecosystem that I am very happy about, and I plan to continue doing so. I have not yet found the time to make a "polished product" out of any of these, but I hope that I can help foster our community such that someday a team will do so. I consider my role, for the time being, to *put ideas out there* through these side projects. - https:/substrate-portfolio/polkadot-portfolio/ - https:/kianenigma/polkadot-basic-notification/ - https:/paritytech/polkadot-scripts/ - https:/paritytech/substrate-debug-kit/ ### Education Lastly, aside from having had a number of educational talks over the years (all of which [are listed](https://hello.kianenigma.nl/talks/) in my personal website), I am a big enthusiast of the newly formed Polkadot Blockchain Academy. I have [been an instructor](https://singular.app/collectibles/statemine/16/2) in the first cohort, and continue to contribute for as long and as much as I can, whilst still attending to the former 3 duties. --- With all of that being said and done, I consider myself at the beginning of the path to Dan 4, but happy to start at a lower one as well.

@kianenigma

# Membership Request Hi, I am Kian Paimani, known as @kianenigma. I have been working on Polkadot/Kusama through Parity since February 2019 and I can categorize my main contributions to Polkadot's ecosystem as follows: 1. Maintaining and developing the staking sub-system. 2. General FRAME development, especially testing and quality assurance. 3. Polkadot-native side-projects. 4. Education > My first contribution to Polkadot is also indeed related to staking: paritytech/substrate#1915 ### Staking system I joke as the Polkadot staking to be both my blessing and my curse over the years. I started working on it since the first days that I joined this ecosystem and the work [is ongoing ever since](https:/orgs/paritytech/projects/33/views/9). In the past, I focused on making sure that the staking system is secure and to some extent scalable. More recently, I coordinated the (imminent) launch of Nomination Pools. Nowadays I also put an extra effort on making sure that this sub-system of Polkadot is *sustainable*, through code refactor and educating other core developers. Lastly, I have been the main author of the [Polkadot staking newsletter](https://gist.github.com/kianenigma/aa835946455b9a3f167821b9d05ba376), which is my main attempt at making the entire complexity and development of this part of the protocol transparent to the end-users. I expect myself to contribute *directly* to the staking system for at least another ~12, if not more, and afterwards having the role of an advisor. Some notable contributions: - paritytech/substrate#4517 - paritytech/substrate#7910 - paritytech/substrate#6242 - paritytech/substrate#9415 - paritytech/polkadot#3141 - paritytech/substrate#11212 - paritytech/substrate#12129 ### FRAME Historically, I have contributed a variety of domains in FRAME, namely: - Early version of the weight system paritytech/substrate#3816 paritytech/substrate#3157 - Early version of the transaction fee system - Primitive arithmetic types paritytech/substrate#3456 - Council election pallet paritytech/substrate#3364 Many of which were, admittedly, a PoC at most, if not considered "poor". I am happy that nowadays many of the above have been refactored and are being maintained by new domain experts. These days, I put most of my FRAME focus on testing and quality assurance. Through my work in the staking system, I have had to deal with the high sensitivity and liveness requirement of protocol development first hand (I believe I had to do among the [very first storage migrations](paritytech/substrate#3948) in Kusama) and consequently I felt the need to make better testing facilities, all of which have been formulated in https://forum.polkadot.network/t/testing-complex-frame-pallets-discussion-tools/356. Some relevant PRs: - paritytech/substrate#8038 - paritytech/substrate#9788 - paritytech/substrate#10174 Regardless of wearing the staking hat, I plan to remain a direct contributor to FRAME, namely because I consider it to be an important requirements of successfully delivering more features to Polkadot's ecosystem. ### Polkadot-Native Side Projects I have started multiple small, mostly non-RUST projects in the polkadot ecosystem that I am very happy about, and I plan to continue doing so. I have not yet found the time to make a "polished product" out of any of these, but I hope that I can help foster our community such that someday a team will do so. I consider my role, for the time being, to *put ideas out there* through these side projects. - https:/substrate-portfolio/polkadot-portfolio/ - https:/kianenigma/polkadot-basic-notification/ - https:/paritytech/polkadot-scripts/ - https:/paritytech/substrate-debug-kit/ ### Education Lastly, aside from having had a number of educational talks over the years (all of which [are listed](https://hello.kianenigma.nl/talks/) in my personal website), I am a big enthusiast of the newly formed Polkadot Blockchain Academy. I have [been an instructor](https://singular.app/collectibles/statemine/16/2) in the first cohort, and continue to contribute for as long and as much as I can, whilst still attending to the former 3 duties. --- With all of that being said and done, I consider myself at the beginning of the path to Dan 4, but happy to start at a lower one as well. Co-authored-by: Bastian Köcher <[email protected]>

kianenigma added 2 commits October 28, 2019 19:49

Initial sotrage migration

fa78aff

Fix some deps

0004b29

pepyakin reviewed Oct 28, 2019

View reviewed changes

srml/elections-phragmen/src/lib.rs Outdated Show resolved Hide resolved

kianenigma commented Oct 28, 2019

View reviewed changes

srml/elections-phragmen/src/lib.rs Outdated Show resolved Hide resolved

test added

8599cb5

kianenigma marked this pull request as ready for review October 28, 2019 19:40

another dep removed

46157cd

xlc reviewed Oct 29, 2019

View reviewed changes

bkchr approved these changes Oct 29, 2019

View reviewed changes

srml/elections-phragmen/src/lib.rs Outdated Show resolved Hide resolved

srml/elections-phragmen/src/lib.rs Outdated Show resolved Hide resolved

srml/elections-phragmen/src/lib.rs Outdated Show resolved Hide resolved

gavofyork reviewed Oct 29, 2019

View reviewed changes

srml/elections-phragmen/src/lib.rs Outdated Show resolved Hide resolved

gavofyork and others added 2 commits October 29, 2019 10:49

Update srml/elections-phragmen/src/lib.rs

4bc5441

Co-Authored-By: Bastian Köcher <[email protected]>

Apply suggestions from code review

832235f

Co-Authored-By: Bastian Köcher <[email protected]>

gavofyork approved these changes Oct 29, 2019

View reviewed changes

a bit nicer

2f2424e

bkchr approved these changes Oct 29, 2019

View reviewed changes

srml/elections-phragmen/src/lib.rs Show resolved Hide resolved

kianenigma mentioned this pull request Oct 29, 2019

Add translate API for storage values #3947

Merged

gavofyork merged commit bf0c5ae into master Oct 29, 2019

gavofyork deleted the kiz-migration-election branch October 29, 2019 14:46

kianenigma added the runtime-migration label Jun 5, 2020

kianenigma mentioned this pull request Sep 27, 2022

Member Request polkadot-fellows/seeding#14

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage migration of elections-phragmen #3948

Storage migration of elections-phragmen #3948

kianenigma commented Oct 28, 2019

kianenigma commented Oct 28, 2019

xlc Oct 29, 2019 •

edited

Loading

bkchr Oct 29, 2019

gavofyork Oct 29, 2019 •

edited

Loading

gavofyork Oct 29, 2019 •

edited

Loading

kianenigma commented Oct 29, 2019

gui1117 commented Oct 29, 2019 •

edited

Loading

kianenigma commented Oct 29, 2019

Storage migration of elections-phragmen #3948

Storage migration of elections-phragmen #3948

Conversation

kianenigma commented Oct 28, 2019

kianenigma commented Oct 28, 2019

xlc Oct 29, 2019 • edited Loading

Choose a reason for hiding this comment

bkchr Oct 29, 2019

Choose a reason for hiding this comment

gavofyork Oct 29, 2019 • edited Loading

Choose a reason for hiding this comment

gavofyork Oct 29, 2019 • edited Loading

Choose a reason for hiding this comment

kianenigma commented Oct 29, 2019

gui1117 commented Oct 29, 2019 • edited Loading

kianenigma commented Oct 29, 2019

xlc Oct 29, 2019 •

edited

Loading

gavofyork Oct 29, 2019 •

edited

Loading

gavofyork Oct 29, 2019 •

edited

Loading

gui1117 commented Oct 29, 2019 •

edited

Loading