Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update wabt to 0.10 and cargo update accross the board #6928

Closed
wants to merge 1 commit into from
Closed

Update wabt to 0.10 and cargo update accross the board #6928

wants to merge 1 commit into from

Conversation

gnunicorn
Copy link
Contributor

@gnunicorn gnunicorn commented Aug 20, 2020 •
edited
Loading

cargo update revealed we are bound to yanked version of wabt. this fixes that

@gnunicorn gnunicorn added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 20, 2020
@tomusdrw tomusdrw mentioned this pull request Aug 21, 2020
Closed
kianenigma
kianenigma approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had this problem for a number of days in my branch and have had manually updated wabt to be able to run my tests. Probably should have reported it earlier.

@gnunicorn
Copy link
Contributor Author

we are still discussing whether to just downgrade to 0.9 to not break older cmake versions...

//cc @tomusdrw , @pepyakin

@bkchr bkchr mentioned this pull request Aug 24, 2020
Closed
@gnunicorn gnunicorn closed this Sep 1, 2020
@gnunicorn gnunicorn mentioned this pull request Sep 7, 2020
Merged
@pepyakin pepyakin mentioned this pull request Sep 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnunicorn @kianenigma