Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Poison with Jason #121

Closed
praveenperera opened this issue Jan 28, 2020 · 2 comments
Closed

Replace Poison with Jason #121

praveenperera opened this issue Jan 28, 2020 · 2 comments

Comments

@praveenperera
Copy link
Contributor

praveenperera commented Jan 28, 2020 •
edited
Loading

Since Jason is faster than Poison and seems to be the go to library for working with JSON in elixir and phoenix should we replace Poison with Jason.

This would mean one less dependency in most projects (since Phoenix comes default with Jason). And Jason seems to be faster the more active library as well.

We could also make the JSON library configurable but default to Jason.

I could make this change.
This was referenced Feb 4, 2020
Open
Merged
parroty added a commit that referenced this issue Feb 9, 2020
@parroty
Merge pull request #123 from cgorshing/feature/fix/121
76c8fc8 
Issue #121 Replace JSON library poison with Jason
@cgorshing
Copy link
Contributor

I believe this can be closed now that the above PR has been merged.

@praveenperera
Copy link
Contributor Author

Awesome! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgorshing @praveenperera