Introduce EMAIL_AUTH=false Environment variable #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes passbolt#70 - allows for setting EMAIL_AUTH=false as environment variable to deactivate SMTP-Auth entirely. This is necessary for internal mailservers / mailtraps / smarthosts, that just expose anonymous port 25.
|
|
|
Hi @justb81 thanks a lot for your contribution to the project!! Apologies for the delay reacting to your PR, we have some other priorities that are consuming our time right now. PR looks good but some changes might be required, this week some testing time will be allocated and your contribution will be merged ASAP. Again thanks. |
|
Hi @dlen if you need any changes, don't hesitate contacting me |
|
@justb81 No changes required, thanks for your contribution 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (which fixes issue #70 ) introduces a new environment variable to disable SMTP authentication.
Just set EMAIL_AUTH to false to ignore smtp authentication. this is useful when operating with internal smarthosts or mailtraps.