Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stamp and Credential Removals #2330

Closed
erichfi opened this issue Mar 25, 2024 · 4 comments · Fixed by #2376
Closed

Stamp and Credential Removals #2330

erichfi opened this issue Mar 25, 2024 · 4 comments · Fixed by #2376
Assignees

Comments

@erichfi
Copy link
Collaborator

erichfi commented Mar 25, 2024

User Story:

As a Passport development team member, I want to remove specific credentials and their associated stamps from the Passport dashboard and scoring model, while ensuring these credentials and stamps are preserved in the database for analytics purposes. This is to streamline the scoring system for users without losing historical data on credential verification and stamp allocation.

Acceptance Criteria

GIVEN a list of credentials to be removed,
WHEN we deploy the next update to the Passport platform,
THEN the specified credentials and their solely associated stamps (if the stamp contains no other credentials) are no longer visible or considered in the scoring model for users but are retained in the database for analytics.

Product & Design Links:

Tech Details:

  • Credentials to be removed:
    • CommunityStakingBronze
    • CommunityStakingGold
    • CommunityStakingSilver
    • GitcoinContributorStatistics#numGrantsContributeToGte#1
    • GitcoinContributorStatistics#numGrantsContributeToGte#10
    • GitcoinContributorStatistics#numGrantsContributeToGte#25
    • GitcoinContributorStatistics#numGrantsContributeToGte#100
    • githubAccountCreationGte#90
    • githubAccountCreationGte#365
    • githubAccountCreationGte#180
    • GuildMember
    • IdenaAge#10
    • IdenaAge#5
    • IdenaStake#100k
    • IdenaStake#10k
    • IdenaStake#1k
    • PHIActivityGold
    • PHIActivitySilver
    • Poh
    • SnapshotVotesProvider
    • twitterAccountAgeGte#180
    • twitterAccountAgeGte#365
    • twitterAccountAgeGte#730
    • ZkSync
    • CyberProfilePremium
    • CyberProfilePaid
    • CyberProfileOrgMember
    • ETHPioneer
  • Ensure that data related to these credentials and stamps is preserved in the database for historical analysis and insights.
  • Update the dashboard UI to reflect the removal of these credentials and associated stamps.
  • Modify the scoring model to exclude these credentials and their solely associated stamps from calculations.

Open Questions:

Notes/Assumptions:

  • Assumes that the user base does not need to take any specific actions in response to these removals.
  • Assumes the removal process is reversible if needed in the future.
  • The database schema and analytics queries will be updated to differentiate between active and decommissioned credentials/stamps for accurate historical analysis.
@nutrina
Copy link
Collaborator

nutrina commented Apr 9, 2024

Questions:

  • do we want to remove this stamps from the code? Or via a configuration in admin?
  • also we will need to change the weights in the scorers, and recalculate
    • shall we also change the weights in the scorers that are marked as exempt? these would be binary weighted scorer 6889 and weighted scorer 6053

@erichfi
Copy link
Collaborator Author

erichfi commented Apr 9, 2024

2 Points

@nutrina
Copy link
Collaborator

nutrina commented Apr 12, 2024

Credentials that have been removed:

  • CommunityStakingBronze
  • CommunityStakingGold
  • CommunityStakingSilver
  • GitcoinContributorStatistics#numGrantsContributeToGte#1
  • GitcoinContributorStatistics#numGrantsContributeToGte#10
  • GitcoinContributorStatistics#numGrantsContributeToGte#25
  • GitcoinContributorStatistics#numGrantsContributeToGte#100
  • githubAccountCreationGte#90
  • githubAccountCreationGte#365
  • githubAccountCreationGte#180
  • GuildMember
  • IdenaAge#10
  • IdenaAge#5
  • IdenaStake#100k
  • IdenaStake#10k
  • IdenaStake#1k
  • PHIActivityGold
  • PHIActivitySilver
  • Poh
  • SnapshotVotesProvider
  • twitterAccountAgeGte#180
  • twitterAccountAgeGte#365
  • twitterAccountAgeGte#730
  • ZkSync
  • CyberProfilePremium
  • CyberProfilePaid
  • CyberProfileOrgMember
  • ETHPioneer

@nutrina
Copy link
Collaborator

nutrina commented Apr 13, 2024

Waiting for PR review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants