Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit entire app -- Capitalize all instances of 'Passport' and 'Stamp' #2881

Closed
lebraat opened this issue Sep 18, 2024 · 4 comments · Fixed by #2922, #2942, passportxyz/passport-scorer#691 or #2943
Assignees

Comments

@lebraat
Copy link
Member

lebraat commented Sep 18, 2024

I've found a few instances of us not capitalizing Passport and Stamp throughout the app.

Specifically, the new 'mint your passport onchain' module, the "xx days until stamps expire", and I'm sure a handful of other locations.

@nutrina
Copy link
Collaborator

nutrina commented Sep 20, 2024

@lebraat just want to double check, the correct spelling would be:

a. Specifically, the new 'mint your PASSPORT onchain' module, the "xx days until STAMPS expire", and I'm sure a handful of other locations.
b. Specifically, the new 'mint your Passport onchain' module, the "xx days until Stamps expire", and I'm sure a handful of other locations.

?

@nutrina nutrina self-assigned this Sep 20, 2024
@lebraat
Copy link
Member Author

lebraat commented Sep 20, 2024

Great callout -- We should move forward with B

@nutrina
Copy link
Collaborator

nutrina commented Sep 25, 2024

@lebraat let's pair on this 15 min today

@nutrina
Copy link
Collaborator

nutrina commented Oct 1, 2024

@lebraat I have deployed another set of fixes to review, they should be live in about ~15 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment