jnp.zeros{,_like} no longer produces a Zero. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is from some discussion in #2. The existing approach is a little bit magic. This also means that we can probably remove dynamic tracing.
patrick-kidger
added a commit
that referenced
this pull request
Dec 21, 2023
This existed just to allow for `jnp.zeros{,_like}` to produce Zeros
even though none of its inputs were. However we have now removed that
as "too magic" (#3), so means that we can simplify this too.
|
Has this PR been supplanted by later refactors? |
|
Not necessarily. The thing I ended up changing was to add a Line 298 in b872ca8 If this flag is set then Quax will be ran against all primitive rules within its dynamic context. (Not just the ones it has data dependency on.) In practice the only one that affects is this one, since it's the only one without dependence on a Quax value. So for now I've set that flag to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from some discussion in #2. The existing approach is a little
bit magic.
This also means that we can probably remove dynamic tracing.