Update batteur.c. Don't use sample_rate from LV2_Options #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise short click and double click is not detected after mod-host commit. //self->sample_rate = (float)opt->value; Looks now that mod-host uses atom_float_uri, sample_rate gets a wrong value. mod-audio/mod-host@0d16999
|
oh dang, that is a very crappy copy&paste bug. |
|
@falkTX do you mean it's rather mod-host not sending the proper value? |
|
yes 100%. and it is not even a float pointer |
|
Fixed in mod-audio/mod-host@3d39e56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//self->sample_rate = (float)opt->value;
Otherwise short click and double click is not detected after newer mod-host commit.
Looks now that mod-host uses atom_float_uri, sample_rate gets a wrong value. mod-audio/mod-host@0d16999