Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra bottom margin to account for keyboard #131

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

MrLightful
Copy link
Contributor

Closes #124

When notification alignment is the bottom part of the screen, add extra margin to account for active keyboard, so the notifications appear above it and not behind.

Breaking changes:

  • Add BuildContext context to ToastificationConfig.marginBuilder signature.

@payam-zahedi
Copy link
Owner

Hey @romatallinn

Thanks for your contribution,

I will review it asap

Copy link
Owner

@payam-zahedi payam-zahedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MrLightful, for your valuable contribution.

I look forward to seeing more PRs from you in the future. I will proceed with merging this PR and will publish it to pub.dev as soon as possible.

@payam-zahedi payam-zahedi merged commit 0227bc7 into payam-zahedi:main Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raising the top of toast with the keyboard open
2 participants