make default theme readable #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pazz
requested changes
Dec 11, 2023
There was a problem hiding this comment.
I do not mind changes to the default theme and if this improves visibility I'm happy with it.
The theme tester script is a welcome addition!
My only two concerns before we can merge this are
- let's squash this into one commit or, even better, have one for the theme and one for the script.
- please run a flake8 or some other python style checker on the script, so that we do not drop on silly code-quality measures
Thanks
|
Sure, no problem, squashed commits and I will move the Python script to another PR. |
|
thanks! |
pazz
approved these changes
Dec 12, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1639