Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When shadowing, end of contest not in sync with primary. #970

Open
johnbrvc opened this issue Jun 3, 2024 · 0 comments
Open

When shadowing, end of contest not in sync with primary. #970

johnbrvc opened this issue Jun 3, 2024 · 0 comments
Labels
bug Something isn't working high priority Bugs that are high priority (to fix) NEXT Contest Consider fixing for next contet Shadow Bugs relating to Shadow Contest Feature

Comments

@johnbrvc
Copy link
Collaborator

johnbrvc commented Jun 3, 2024

Describe the issue:
When shadowing, it is possible that PC2 will mark runs as DELeted even though they are valid.

To Reproduce:
Hard to reproduce reliably, but we have seen it at during WF system tests, and the NAC2024 real contest.
See the behavior sections below for a description.

Expected behavior:
PC2 should accept submissions without marking them as DEL until a END Contest state is received from the primary. Currently, it is possible that PC2's contest clock runs out a split second before the END state change is seen from the primary. This causes PC2 to think the contest is over prematurely, and, as a result, some runs may be marked as DEL and have to be hand-edited.

Actual behavior:
Submissions at the end of a contest come in very quickly right up until the buzzer. As a result, PC2 may think the contest is over (its contest clock has finished) before the notification from the primary indicating contest stop. The primary should be the authoritative clock for a contest. (State messages on the event feed).

Environment:
All

Log Info:

Screenshots:

Additional context:

@johnbrvc johnbrvc added bug Something isn't working high priority Bugs that are high priority (to fix) Shadow Bugs relating to Shadow Contest Feature NEXT Contest Consider fixing for next contet labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Bugs that are high priority (to fix) NEXT Contest Consider fixing for next contet Shadow Bugs relating to Shadow Contest Feature
Projects
None yet
Development

No branches or pull requests

1 participant