Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I983 custom honors solved count #1001

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

SamanwaySadhu
Copy link
Collaborator

Description of what the PR does

Add option to customize the minimum number of problems solved to get Highest Honors, High Honors or Honors through the Finalize Pane in case we're using WF style rankings.

Issue which the PR addresses

Fixes #983

Environment in which the PR was developed (OS, IDE, Java version, etc.)

Windows 10, Eclipse 2021-12 R, JDK 8u381 (1.8), C++ 13.2.0

Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)

  • Run the Ant script build.xml in the pc2v9 project.
  • Start a PC2 server, loading some prefinalized contest profiles folder and profiles.properties files.
  • Start a PC2 Admin.
  • Go to Run Contest and Finalize tab to toggle between WF group rankings checkbox.
    image
  • Once you click on the Customize check box, the text fields will be activated and you can enter the values you want and then press Update.
  • Click the View button to check if changes take effect.
  • Click on the tool tip to get a detailed understanding how the Default and Custom values will work in the ranking algorithm.

1. If WF style rankings then Highest Honors, High Honors and Honors are assigned, based on new "Bill" rules.
2. Standings Record Comparator now uses case insensitive comparator for account names.
3. Account Name Comparator is updated to make accent insensitive.
1. Removed wf2017 from test data as it was not compliant with Bill's new rules
2. Added wf47 data and new results.tsv generated by DOMjudge compliant with Bill's new rules
3. Updated algorithm to consider 0 solved problems as "Honorable" no matter what
4. For non-WFGroups consider only isHonor (equivalent to isRanked)
5. Updated expected results of test cases for 0 solved problems cases.
…lues\n2) Update Reload Frame to handle Enabling/Disabling of Swing Utilities Correctly.
@johnbrvc johnbrvc assigned johnbrvc and SamanwaySadhu and unassigned johnbrvc Aug 19, 2024
1 - Handle null condition for finalizeData in ResultsFile
2 - CI: Remove repetitive code on FinalizePane.java
@johnbrvc johnbrvc self-requested a review August 24, 2024 17:00
Copy link
Collaborator

@johnbrvc johnbrvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes made.

@SamanwaySadhu

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contingency for High Honors and Honors ranking groups
2 participants