I978: Update generated results file according to new WF honor degrees proposed by Bill #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. If WF style rankings then Highest Honors, High Honors and Honors are assigned, based on new "Bill" rules. 2. Standings Record Comparator now uses case insensitive comparator for account names. 3. Account Name Comparator is updated to make accent insensitive.
…r compare which was not perfect
1. Removed wf2017 from test data as it was not compliant with Bill's new rules 2. Added wf47 data and new results.tsv generated by DOMjudge compliant with Bill's new rules 3. Updated algorithm to consider 0 solved problems as "Honorable" no matter what 4. For non-WFGroups consider only isHonor (equivalent to isRanked) 5. Updated expected results of test cases for 0 solved problems cases.
…ors with multiple solvd problems
johnbrvc
approved these changes
Jul 25, 2024
|
@SamanwaySadhu You can add your name as the author on the new module you created for the CSV report. Credit where credit is due! |
This comment was marked as resolved.
This comment was marked as resolved.
kkarakas
approved these changes
Aug 6, 2024
clevengr
reviewed
Aug 20, 2024
clevengr
reviewed
Aug 20, 2024
clevengr
reviewed
Aug 20, 2024
clevengr
reviewed
Aug 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
johnbrvc
reviewed
Aug 24, 2024
johnbrvc
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Highest Honors,High HonorsandHonorsinstead of simplyRankedbased on the rules proposed by Bill.results.csvfile as well.Issue which the PR addresses
Fixes #978
Environment in which the PR was developed (OS, IDE, Java version, etc.)
Windows 10, Eclipse 2021-12 R, JDK 8u381 (1.8), C++ 13.2.0
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
profilesfolder andprofiles.propertiesfiles.Run ContestandFinalizetab to toggle between WF group rankings checkbox.Reportsin eitherAdminorServer.results.csvorresults.tsvreport.Comment
Checking success for JUnits is enough to test functionality of this PR. The JUnits have been recently curated based on WF 47 and the corresponding
results.tsvin testdata has been generated by DOMjudge based on the new Bill's rules. Check the synthetic data of JUnits as well to review how code will behave under various edge cases.