Relax activesupport version constraint #59

mlarraz · 2019-04-10T19:14:59Z

Right now this prevents installing any patch releases of Rails 5.2.

Given the Gemfile:

source 'https://rubygems.org'

gem 'flip', github: 'pda/flip'
gem 'activesupport', '~> 5.2.3'

Running bundle install gives:

Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    activesupport (~> 5.2.3)

    flip was resolved to 1.1.1, which depends on
      activesupport (>= 4.0, <= 5.2)

montanalow · 2019-05-31T02:41:53Z

flip.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |s|
 s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
 s.require_paths = ["lib"]

- s.add_dependency("activesupport", ">= 4.0", "<= 5.2")


activesupport uses good deprecation and consistent migration paths for end users. Gems should typically avoid upper bounding on widely shared and well tested dependencies, unless there are known incompatibilities.

Relax activesupport version constraint

96c6cd1

montanalow reviewed May 31, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relax activesupport version constraint #59

Relax activesupport version constraint #59

mlarraz commented Apr 10, 2019

montanalow May 31, 2019

Relax activesupport version constraint #59

Are you sure you want to change the base?

Relax activesupport version constraint #59

Conversation

mlarraz commented Apr 10, 2019

montanalow May 31, 2019

Choose a reason for hiding this comment