fix: Disable deprecated Flow Control & use async
/ await
#35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Turns out Protractor uses this thing called "Webdriver Flow Control" to handle test command execution. It relies on promises to know when to go to the next step in the tests.
Flow Control is deprecated (see: SeleniumHQ/selenium#2969) and will be removed. This is because packages / tests that use
async
/await
don't quite work with Flow Control due to the difference in promise interfaces (I'm assuming native promises vs polyfills).Protractor recommends using
async
/await
now (https://www.protractortest.org/#/control-flow):This PR also removes the windows test commands since they're not needed anymore. 👍