Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bundle version tracking overwrites files #6

Open
vvidic opened this issue Dec 4, 2015 · 1 comment
Open

New bundle version tracking overwrites files #6

vvidic opened this issue Dec 4, 2015 · 1 comment
Assignees

Comments

@vvidic
Copy link
Contributor

vvidic commented Dec 4, 2015

Bundle packages now (#5) use /var/lib/perfsonar/bundles/bundle_type and /var/lib/perfsonar/bundles/bundle_version files for storing current current bundle type and version. These files get overwritten in postinst scripts of respective packages, so the end result depends on the order the bundle packages are installed or reconfigured:

# grep . /var/lib/perfsonar/bundles -r
/var/lib/perfsonar/bundles/bundle_version:3.5-1+0~20151204120702.305~1.gbpf53833
/var/lib/perfsonar/bundles/bundle_type:perfsonar-core

# dpkg-reconfigure perfsonar-tools

# grep . /var/lib/perfsonar/bundles -r
/var/lib/perfsonar/bundles/bundle_version:3.5-1+0~20151204120702.305~1.gbpf53833
/var/lib/perfsonar/bundles/bundle_type:tools

Also the cleanup is not correct when the package is removed.

We could use a more complex but a stable system like this:

%post TestPoint
mkdir /var/lib/perfsonar/bundles/10_test-point
echo "%{version}" > /var/lib/perfsonar/bundles/10_test-point/version

%post Core
mkdir /var/lib/perfsonar/bundles/20_perfsonar-core
echo "%{version}" > /var/lib/perfsonar/bundles/20_perfsonar-core/version

%post Complete
mkdir /var/lib/perfsonar/bundles/30_perfsonar-complete
echo "%{version}" > /var/lib/perfsonar/bundles/30_perfsonar-complete/version

The code can than sort the directory names and read the appropriate version file.

@laeti-tia laeti-tia added this to the 3.5.1 milestone Dec 7, 2015
@laeti-tia
Copy link
Member

This would need to be changed both in the Debian and RPM packages and also change the code from Version.pm that reads the version information as it was done in #5.

@arlake228 arlake228 modified the milestones: 3.6, 3.5.1 Jan 20, 2016
@arlake228 arlake228 modified the milestones: 4.0, 3.6 Nov 10, 2016
@arlake228 arlake228 self-assigned this Nov 10, 2016
@arlake228 arlake228 modified the milestones: 4.1, 4.0 Jan 18, 2017
@laeti-tia laeti-tia self-assigned this Apr 4, 2017
@arlake228 arlake228 removed this from the 4.1 milestone May 8, 2017
@bltierney bltierney modified the milestones: 4.0.1, 4.1b1 May 13, 2017
@arlake228 arlake228 removed this from the 4.1b1 milestone May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

4 participants