Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When tests are focused via DSL, exit with a non-zero code. #204

Merged
merged 1 commit into from
Jan 9, 2017
Merged

When tests are focused via DSL, exit with a non-zero code. #204

merged 1 commit into from
Jan 9, 2017

Conversation

ezzatron
Copy link
Contributor

@ezzatron ezzatron commented Jan 9, 2017

This PR implements a similar feature to this one from Ginkgo:

When Ginkgo detects that a passing test suite has a programmatically focused test it causes the suite to exit with a non-zero status code. This is to help detect erroneously committed focused tests on CI systems. When passed a command-line focus/skip flag Ginkgo exits with status code 0 - if you want to focus tests on your CI system you should explicitly pass in a -focus or -skip flag.

@codecov-io
Copy link

codecov-io commented Jan 9, 2017 •
edited
Loading

Current coverage is 97.14% (diff: 100%)

No coverage report found for master at 11aa12c.

Powered by Codecov. Last update 11aa12c...300ec4e

@ezzatron ezzatron merged commit 25ec1ce into master Jan 9, 2017
@ezzatron ezzatron deleted the focus-safety branch January 9, 2017 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezzatron @codecov-io