Skip to content

Commit

Permalink
ci: bump toolchain for check (#978)
Browse files Browse the repository at this point in the history
* allow the existing partial_cmp
  • Loading branch information
tomtau authored Feb 12, 2024
1 parent da27a16 commit a0a92fb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: ./.github/actions/setup
with:
kind: check
toolchain: 1.70.0
toolchain: 1.74.0 # needed for `clap` in pest_debugger
- name: cargo check
run: cargo check --all --features pretty-print,const_prec_climber,memchr,grammar-extras --all-targets

Expand All @@ -40,7 +40,7 @@ jobs:
with:
kind: check
components: clippy, rustfmt
toolchain: 1.70.0
toolchain: 1.74.0 # needed for `clap` in pest_debugger
- name: cargo fmt
run: cargo fmt --all -- --check
- name: cargo clippy
Expand All @@ -62,7 +62,7 @@ jobs:
id: setup
with:
kind: check
toolchain: 1.70.0
toolchain: 1.74.0 # needed for `clap` in pest_debugger
- name: cargo doc
run: cargo doc --all --features pretty-print,const_prec_climber,memchr,grammar-extras

Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
id: setup
with:
kind: check
toolchain: 1.70.0
toolchain: 1.74.0 # needed for `clap` in pest_debugger
- name: Check feature powerset
run: cargo hack check --feature-powerset --optional-deps --exclude-all-features --skip not-bootstrap-in-src,cargo --keep-going --lib --tests --ignore-private

Expand Down
1 change: 1 addition & 0 deletions pest/src/position.rs
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,7 @@ impl<'i> PartialEq for Position<'i> {

impl<'i> Eq for Position<'i> {}

#[allow(clippy::non_canonical_partial_ord_impl)]
impl<'i> PartialOrd for Position<'i> {
fn partial_cmp(&self, other: &Position<'i>) -> Option<Ordering> {
if ptr::eq(self.input, other.input) {
Expand Down

0 comments on commit a0a92fb

Please sign in to comment.