Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{action "something"}} gets converted to {{action this.something}} #1

Open
GoygovRustam opened this issue Jun 12, 2020 · 2 comments
Open

Comments

@GoygovRustam
Copy link

Input:

<a href={{this.targetHREF}} {{action "showMessaging"}} >
  Test Link
  </a>

Actual Result

<a href={{this.targetHREF}} {{action this.showMessaging}} >
  Test Link
  </a>

Expected Result:

<a href={{this.targetHREF}} {{on "click" this.showMessaging}} >
  Test Link
  </a>
@pete-the-pete
Copy link
Owner

@GoygovRustam , I added a test for this case and it passes, so I think this needs more investigation.

@pete-the-pete
Copy link
Owner

bca7f3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants