-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pex 2.1.93 pex --lock
artifact downloading fails for sdists with ext_modules or PEP-517 build systems.
#1817
Comments
This was spotted over in pantsbuild/pants#15990 |
Aha, the explanation is here: pypa/pip#1884 (comment) |
But then you'd think this would work with modern Pip that supports
|
Aha, the more on-point explanation is here: pypa/pip#1884 (comment) - basically, legacy code in Pip mooshes download and prepare together and that's hard to untangle easily. |
As of Pex 2.1.93, sdists that built native extensions or used a PEP-517 build system would not be successfully downloaded when constructing a PEX from a lock. Fixes pex-tool#1817
As of Pex 2.1.93, sdists that built native extensions or used a PEP-517 build system would not be successfully downloaded when constructing a PEX from a lock. Fixes #1817
Even though we download lock artifacts using
pip download --no-deps
, Pip still tries to execute the build system. Maybe to gather metadata? I'm really not sure why it does this; no metadata is needed:lock.json:
Leads to:
So #1811, which switched Pex to using
pip download --no-deps
to download lock artifacts, fails for various sdists.The text was updated successfully, but these errors were encountered: