Build also as a shared library and add install target #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirutka
changed the title
lfittl
reviewed
May 7, 2021
There was a problem hiding this comment.
@jirutka Thanks for the contribution!
Whilst I'm not sure if its a good idea to use libpg_query as a shared library, and it was written with a static library in mind, it doesn't hurt either I think.
My only requests here are to avoid building the shared library by default, and to include the minor version in the SONAME (since it's likely we'll break the ABI in a minor release sometimes).
|
I made the requested changes. Could you please take a second look? |
lfittl
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW: I’ve packaged libpg_query and ruby-pg_query for Alpine Linux. It’s built with patches from this PR and few others to unbundle dependencies.