Don't bail on #? operator name #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following statement will produce an error with pg_query_parse while being accepted by PG13. CREATE OPERATOR #? (LEFTARG=bool,RIGHTARG=bool,FUNCTION=boolge); pganalyze#132
lfittl
approved these changes
Apr 20, 2022
lfittl
added a commit
to pganalyze/collector
that referenced
this pull request
Jun 28, 2022
Relevant changes that apply to the collector: - Fixes memory leak in pg_query_fingerprint error handling [#141](pganalyze/libpg_query#141) - Add support for parsing more operators that include a `?` character (special cased to support old pg_stat_statements query texts) - ltree extension [#136](pganalyze/libpg_query#136) - promscale extension [#133](pganalyze/libpg_query#133)
lfittl
added a commit
to pganalyze/collector
that referenced
this pull request
Jun 29, 2022
Relevant changes that apply to the collector: - Fixes memory leak in pg_query_fingerprint error handling [#141](pganalyze/libpg_query#141) - Add support for parsing more operators that include a `?` character (special cased to support old pg_stat_statements query texts) - ltree extension [#136](pganalyze/libpg_query#136) - promscale extension [#133](pganalyze/libpg_query#133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following statement will produce an error with pg_query_parse
while being accepted by PG13.
CREATE OPERATOR #? (LEFTARG=bool,RIGHTARG=bool,FUNCTION=boolge);
#132