Additional deparser fixes for Postgres 16 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfittl
commented
Dec 22, 2023
| @@ -246,89 +251,144 @@ static void deparseAnyNameSkipLast(StringInfo str, List *parts) | |||
| } | |||
| } | |||
|
|
|||
| // "a_expr" / "b_expr" in gram.y | |||
| static void deparseExpr(StringInfo str, Node *node) | |||
There was a problem hiding this comment.
This refactoring maps the deparser handling of a/b/c type expressions closer to how gram.y is written, and helps us only add parentheses around a_expr type expressions when needed (i.e. when they are used within the context of a c_expr).
lfittl
force-pushed
the
16-latest-dev-deparser
branch
from
0b3a90e
to
dab4191
Compare
msepga
approved these changes
Dec 22, 2023
Additionally add missing regression tests, except for sqljson, which needs additional work.
This seems acceptable performance wise, and gives additional context.
lfittl
force-pushed
the
16-latest-dev-deparser
branch
from
dab4191
to
ab076d2
Compare
msepga
added a commit
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #225.
This makes all SQL contained in Postgres 16 regression tests work successfully with the deparser.