Remove previous JWS validation and structs #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the switch from the old `release` field to the new `certs` and `release` fields as defined in [RFC 5] and implemented in 0773ad7 and acb0d22, the previously-defined JSON schemas and data structure are no longer used. So remove them and their tests. [RFC 5]: pgxn/rfcs#5
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1131 1105 -26
=========================================
- Hits 1131 1105 -26 ☔ View full report in Codecov by Sentry. |
vrmiguel
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch from the old
releasefield to the newcertsandreleasefields as defined in RFC 5 and implemented in 0773ad7 and acb0d22, the previously-defined JSON schemas and data structure are no longer used. So remove them and their tests.