Skip to content

Commit

Permalink
ngrx#378 Default selectId function for EntityAdapter
Browse files Browse the repository at this point in the history
  • Loading branch information
phillipzada committed Sep 19, 2017
1 parent 90901e3 commit dec974c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 118 deletions.
1 change: 0 additions & 1 deletion modules/effects/testing/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
export * from './src/testing';
export * from './src/toEqualObservable';
116 changes: 0 additions & 116 deletions modules/effects/testing/src/toEqualObservable.ts

This file was deleted.

5 changes: 4 additions & 1 deletion modules/entity/src/create_adapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@ import { createSelectorsFactory } from './state_selectors';
import { createSortedStateAdapter } from './sorted_state_adapter';
import { createUnsortedStateAdapter } from './unsorted_state_adapter';

export function createEntityAdapter<T>(options: {
export function createEntityAdapter<T>(): EntityAdapter<T>;
export function createEntityAdapter<T>(options?: {
selectId: IdSelector<T>;
sortComparer?: false | Comparer<T>;
}): EntityAdapter<T> {
options = options || { selectId: (instance: any) => instance.id };

const { selectId, sortComparer }: EntityDefinition<T> = {
sortComparer: false,
...options,
Expand Down

0 comments on commit dec974c

Please sign in to comment.