remove case of 2 tuple of :pi #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @derek-zhou! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
|
@derek-zhou I think so. Strangely we didn't treat that case in the selectors. |
|
@derek-zhou thank you! 💜 |
inoas
added a commit
to inoas/floki
that referenced
this pull request
Aug 24, 2022
* master: (23 commits) Bump ex_doc from 0.28.4 to 0.28.5 (philss#416) Bump earmark from 1.4.26 to 1.4.27 (philss#415) Bump credo from 1.6.5 to 1.6.6 (philss#414) Bump dialyxir from 1.1.0 to 1.2.0 (philss#413) Bump credo from 1.6.4 to 1.6.5 (philss#412) Show retrieval of data attributes (philss#410) Release v0.33.1 Improve the README.md file Fix warnings related to the tokenizer Change sponsors links - using GitHub Sponsors Release v0.33.0 Added case insentive variation of fl-contains (philss#409) Bump html5ever from 0.13.0 to 0.13.1 (philss#407) Bump earmark from 1.4.25 to 1.4.26 (philss#406) Minor stuff I changed while reading (philss#404) Bump earmark from 1.4.24 to 1.4.25 (philss#403) Bump html5ever from 0.12.0 to 0.13.0 (philss#401) Bump ex_doc from 0.28.3 to 0.28.4 (philss#402) Remove case of 2 for tuple of :pi (philss#400) Bump earmark from 1.4.23 to 1.4.24 (philss#398) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like this? I didn't check the html5ever and fast_html parsers.
#399