Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unused dependencies check step to CI #435

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

antedeguemon
Copy link
Contributor

Hey there!

This is a simple quality-of-life check to ensure no unused dependencies are locked by mix.lock.

@antedeguemon antedeguemon changed the title Add unused dependency check step to CI Add unused dependencies check step to CI Nov 4, 2022
@philss
Copy link
Owner

philss commented Nov 4, 2022

@antedeguemon thank you for the PR! 💜
I think this won't work because we have different dependencies for each parser.

Perhaps we could declare all of them normally in the mix.exs file, since they don't take too much time to build now. Can you give it a try?

Copy link
Owner

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Much better now! :shipit:

@philss philss merged commit a16cf5e into philss:main Nov 4, 2022
@antedeguemon
Copy link
Contributor Author

@philss yay! I've removed the PARSER environment variable and its related logic.

CI time stayed pretty close:

@antedeguemon antedeguemon deleted the vm-adds-unused-deps-check-to-ci branch November 4, 2022 21:18
@philss
Copy link
Owner

philss commented Nov 4, 2022

@antedeguemon Nice! I noticed that we are installing the Rust toolchain, but I think this is not necessary anymore, since html5ever is using a precompiled binary. If you want to remove that from the workflow, feel free to send a PR :) (otherwise I can take this later).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants