Remove outdated gleam wrapper code #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The external functions syntax in Gleam has changed: https://gleam.run/book/tour/external-functions.html There's also no easy way to use this code from a gleam project that just has the floki dependency added with the gleam build tool. I think it's safe to say that no one is using this. Likely a better way to wrap Floki in Gleam would be to make a separate Gleam package with floki as a dependency, and wrap the API there - maybe then the package could also provide a more Gleam-y API than "here's an opaque thing, decode it if you want"
|
@michallepicki Makes sense! Thank you! I'm going to assume that no one is using. If anyone needs a wrapper, please go ahead and create a new package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external functions syntax in Gleam has changed: https://gleam.run/book/tour/external-functions.html
There's also no easy way to use this code from a gleam project that just has the floki dependency added with the gleam build tool. I think it's safe to say that no one is using this. Likely a better way to wrap Floki in Gleam would be to make a separate Gleam package with floki as a dependency, and wrap the API there - maybe then the package could also provide a more Gleam-y API than "here's an opaque thing, decode it if you want"