Look up tailwind.config.js anywhere in the app directory (except dirs ignored explicitly)

[trinitytakei]

The Problem

As discussed here: https://discord.com/channels/1082611227827638303/1254781033791098940 , tailwind.config.js can show up in several places in a Rails app, based on how/when you installed Tailwind.

However, the Phlex install generator currently assumes that tailwind.config.js should always be in the Rails.root directory. This can lead to some surprises if the user installing Phlex has the file somewhere else (config/tailwind.config.js if installed with the tailwind-rails generator, or app/javascript/stylesheets/tailwind.config.js for older (I'm guessing webpacker) apps; possibly other places, depending on your JS bundler config and whatnot).

The Proposed Solution

This PR aims to rectify the situation by looking up the location of tailwind.config.js. Except some directories explicitly ignored by the generator (like node_modules, vendor and such), it will look fortailwind.config.js anywhere in the app directory.

EDIT after @joeldrapper's review: It's cleaner and more maintainable to go with the whitelist approach ("look here: ... ") than the blacklist one ("look anywhere BUT here: ..."). Just keep in mind that your tailwind.config.js config has to be in either

• Rails.root
• app/**
• config/**

🤔

I'm assuming the previous implementation semantic was something like "If tailwind.config.js is not in Rails.root, this application is not using Tailwind, thus there's no need to apply any changes to tailwind.config.js, kthxbye".

The current one is along the lines of "If you are using Tailwind, and you are not doing something extremely crazy (like having multiple tailwind.config.js files or storing them outside of the sensible directories (Rails.root, app/**, config/**), we'll find the file and apply the modifications".

[joeldrapper]

I don’t like the idea of Phlex maintaining an ignore list that users can’t update. Instead, could we look in just app/** and config/**, ignoring everything else?

[trinitytakei]

Totally! See updated PR.

could we look in just app/** and config/**

I also added "#{Rails.root}/tailwind.config.js" for good measure 😅

[joeldrapper]

Thanks for opening this and sorry it took so long to review.

[trinitytakei]

No worries, summer is slow season over here as well!

[trinitytakei]

Yet another questionable Rubocop thingamajig 😵‍💫

Not sure how to handle these (now and in the future)?

[joeldrapper]

Just do it the way you feel is right and we’ll adjust the Rubocop configuration accordingly.

[trinitytakei]

@joeldrapper I believe this is good to go as well (at least Rubocop / bin/test are 🟢).