-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App/Bookmarks/Greeter/System] Custom greeter, make apps and bookmarks open in new tabs, support for .yaml files, editor frontend #16
Comments
Hi! I'll go through your list one by one:
|
Actually, I think a good start would be to just accept yaml files for configuration purposes. The rational for this is that yaml notation is easier to read than json notation. Hence, there is also less risk of making stupid errors when editing the configuration. For instance, your sample file apps.json would look something like this:
There exist numerous libraries in different languages for converting yaml to json, so not much (if anything) need to change with the existing code. To actually add capability for also editing the config files in the browser would be even better, but it is also a bigger undertaking. In all honesty, I have never looked into how this can be accomplished in practice. However, one example of a project who has it working is Portainer.io. The setup of docker stacks can be done using a web editor. The image below shows how I created a stack that basically just start dashboard using docker-compose. |
Just a quick update here:
Kind regards |
+1 to open links in a new tab EDIT: While reading the code, I noticed that adding |
Cool catch, directly implemented the newTab: true |
Just implemented this for bookmarks. |
Hey phntxx, it's a nice little dashboard you have created here. I have a few suggestions for improvements that you might consider:
Thanks for your good work!
The text was updated successfully, but these errors were encountered: